search

loris-imageserver / loris

Loris IIIF Image Server
Other
208 stars 87 forks source link

Loris sends (undesirably) sends rules.json for every image resolution #492

Closed minusdavid closed 4 years ago

minusdavid commented 4 years ago

It would be nice to disable the sending of the rules.json request, as it's creating unnecessary HTTP traffic

bcail commented 4 years ago

@minusdavid thanks, I agree. I'll work on that, but first I have a general question for anyone.

@azaroth42, @alexwlchan, anyone: The ImageInfo class takes in an "extra" parameter, which contains authentication information (coming from the rules.json file for the image), but the extra parameter also contains "extraInfo", which can set non-auth information like the logo, attribution, and license for the image info (see https://github.com/loris-imageserver/loris/blob/development/loris/img_info.py#L83, https://github.com/loris-imageserver/loris/blob/development/loris/img_info.py#L95, https://github.com/loris-imageserver/loris/blob/development/tests/img_info_t.py#L265). Is that functionality being used? Ie. are rules.json files being used for non-auth information (like logo, license, ...) for images, or can we limit the rules.json file handling to just auth information?

alexwlchan commented 4 years ago

are rules.json files being used for non-auth information (like logo, license, ...) for images

We’re not using rules.json at all at Wellcome, so no.

azaroth42 commented 4 years ago

We used to use it for that, but have switched away from Loris.

bcail commented 4 years ago

should be fixed in #495.