Normalize content-type before extention computation in SimpleHTTPResolver

loris-imageserver / loris

Loris IIIF Image Server

Other

208 stars 87 forks source link

Open damooo opened 4 years ago

damooo commented 4 years ago

fixes #508

alexwlchan commented 4 years ago

Thanks for raising this issue, and the initial patch!

Two suggestions:

We should use cgi.parse_header() instead of writing our own code to parse the Content-Type header. It’s more likely to handle other edge cases and be robust against other unexpected Content-Type headers.
Could you add a test for your change please?

damooo commented 4 years ago

It now uses cgi.parse_header, test case updated to issue complex content-type

damooo commented 3 years ago

Hello @alexwlchan, can you merge this patch, so that issue can be fixed?