lorisleiva / laravel-actions

⚡️ Laravel components that take care of one specific task
https://laravelactions.com
MIT License
2.52k stars 124 forks source link

Uninstalling Deletes Laravel Jetstream Actions #113

Closed gdconnect closed 3 years ago

Wulfheart commented 3 years ago

What exactly do you mean?

gdconnect commented 3 years ago

Deletes all contents of the /Actions folder.. including Jetstream and Fortify Actions . upon uninstall

On Thu, 27 May 2021 at 05:51, Alex @.***> wrote:

What exactly do you mean?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lorisleiva/laravel-actions/issues/113#issuecomment-849072709, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB5JQXT72MQRW2G3AX4525DTPVGLFANCNFSM4453QISQ .

Wulfheart commented 3 years ago

And how do you uninstall it? Is there a special command?

gdconnect commented 3 years ago

composer remove lorisleiva/laravel-actions

Not aware of special command for uninstalling

On Thu, 27 May 2021 at 16:10, Alex @.***> wrote:

And how do you uninstall it? Is there a special command?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lorisleiva/laravel-actions/issues/113#issuecomment-849353985, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB5JQXUVBZMVDKYPIIGL65TTPXO3TANCNFSM4453QISQ .

Wulfheart commented 3 years ago

I cannot reproduce this issue. Please provide more specific information with information about your system. Here a snippet for you to copy-paste:

### System (please complete the following information):
 - OS: [e.g. macOS, Manjaro Linux, Windows 10]
 - PHP Version: [e.g. 8.0.3]
 - composer Version: [e.g. 2.0.0]
 - Package Version from the lock-file: [e.g. 0.2.2]
 - Laravel Version from the lock-file: [e.g. 8.5.2]
 - Shell: [e.g. Powershell, cmd, bash, zsh]

My Reproduction try

System:

Reproduction script for bash

composer create-project laravel/laravel issue -q && cd issue && composer require laravel/jetstream lorisleiva/laravel-actions -q && php artisan jetstream:install livewire -q && php artisan make:action TestAction -q && composer remove lorisleiva/laravel-actions -q && printf "\nContents of the app/Actions Folder\n\n" && ls -lac ./app/Actions

Result

As expected:

Contents of the app/Actions Folder

total 20
drwxr-xr-x 4 alexw alexw 4096 May 27 12:05 .
drwxr-xr-x 9 alexw alexw 4096 May 27 12:05 ..
drwxr-xr-x 2 alexw alexw 4096 May 27 12:05 Fortify
drwxr-xr-x 2 alexw alexw 4096 May 27 12:05 Jetstream
-rw-r--r-- 1 alexw alexw  170 May 27 12:05 TestAction.php
lorisleiva commented 3 years ago

Hi there 👋

Thanks Alex for looking into this. I'm going to close this due to inactivity and lack of information but feel free to open a new issue with a more detailed description of the issue and how to reproduce it so we can fix it.