search

lorisleiva / laravel-actions

⚡️ Laravel components that take care of one specific task
https://laravelactions.com
MIT License
2.52k stars 124 forks source link

CreatesMatchingTest not found #177

Closed soipo closed 8 months ago

soipo commented 2 years ago

Hi there, it seems like the CreatesMatchingTest has been removed, I am unable to update my dependencies.

`Trait "Illuminate\Console\Concerns\CreatesMatchingTest" not found

at vendor/lorisleiva/laravel-actions/src/Console/MakeActionCommand.php:8 4▕ 5▕ use Illuminate\Console\Concerns\CreatesMatchingTest; 6▕ use Illuminate\Console\GeneratorCommand; 7▕ ➜ 8▕ class MakeActionCommand extends GeneratorCommand 9▕ { 10▕ use CreatesMatchingTest; 11▕ 12▕ protected $name = 'make:action'; `

Any suggestion ? Perhaps using CallsCommands in stead ?

soipo commented 2 years ago

https://github.com/lorisleiva/laravel-actions/compare/main...soipo:patch-1

renepardon commented 2 years ago

Same problem here.. using version 2.4.0

Downgrade to 2.2.0 works for now

lorisleiva commented 1 year ago

Hi there 👋

Is this still an issue? If so, could you please open a PR? 🙏

renepardon commented 1 year ago

main...soipo:patch-1

@lorisleiva doesn’t this one fix it?

lorisleiva commented 1 year ago

Well, I'm not entirely sure this change fixes the described issue as it replaces a trait with a completely different one.

Additionally, it doesn't seem like the CreatesMatchingTest trait has been removed from the framework. If it was, the tests should fail as they run for both the earliest and latest version possible within the provided range.

Would you be able to provide steps to reproduce the issue?