Remove return type for make()

lorisleiva / laravel-actions

⚡️ Laravel components that take care of one specific task

https://laravelactions.com

MIT License

2.52k stars 124 forks source link

Remove return type for make() #287

Closed Casmo closed 3 months ago

Casmo commented 3 months ago

Remove static return type. See https://github.com/lorisleiva/laravel-actions/pull/285#issuecomment-2296463178

lorisleiva commented 3 months ago

Thank you! 🍺

Two small things before merging:

Is there a small regression test we can add here to make sure we don't make that mistake again in the future?
@edwinvdpol just checking if you're happy with that change as well.

Casmo commented 3 months ago

Done!

lorisleiva commented 3 months ago

Thanks!

austincarpenter commented 2 months ago

This has broken IDE autocompletion for me. Now PhpStorm thinks handle() when called via ::make()->handle(...) points to vendor/laravel/framework/src/Illuminate/Foundation/Application.php's handle() method.

I deliberately don't use the ::run() syntax for this reason.

lorisleiva commented 2 months ago

@austincarpenter Hi there, this was a partial revert of https://github.com/lorisleiva/laravel-actions/pull/285 which was only published a patch version earlier (in the matter of days). When did you experience that autocompletion working and then not working?

austincarpenter commented 2 months ago

@lorisleiva Prior to #285 it was working due to the docblock, also after due to the return type and now post #287 it's not due to neither a docblock nor a return type.

lorisleiva commented 2 months ago

Gotcha, so we just need the docblock back right? If so, would you be able to submit a small PR for this and I'll get that merged/patched immediately?

austincarpenter commented 2 months ago

Apologies for the delay on this one. Thanks @TaylorWilton @lorisleiva 👏