lorisleiva / laravel-docker

🐳 Generic docker image for Laravel Applications
MIT License
927 stars 312 forks source link

wkhtmltopdf issue for 7.4 #108

Open DmitrySidorenkoShim opened 2 years ago

DmitrySidorenkoShim commented 2 years ago

After this merge
we had an issue with wkhtmltopdf for lorisleiva/laravel-docker:7.4 image
because it is installed for alpine3.13 but don't for alpine3.15

Resolved by creating our own image in Container Registry in GitLab
with previous version of 7.4/Dockerfile but it takes some time to find out the problem and resolve the issue.

Nothing critical but wanted to let you know about this.
And it would be awesome if you can take a look at this and resolve.
Thank you in advance.

lorisleiva commented 2 years ago

Hi there 👋

Hmm, I'm not sure what you mean, this package has never explicitly supported wkhtmltopdf.

I don't think it would be part of the default Alpine image either so I'm not sure how this was working before.

DmitrySidorenkoShim commented 2 years ago

Thanks for quick reply

oh... true
it was installed later in .gitlab-ci.yaml apk add --update-cache ... wkhtmltopdf
but this started to throw an error since yesterday

ERROR: unable to select packages: wkhtmltopdf (no such package): required by: world[wkhtmltopdf]

and then I found last merge to lorisleiva/laravel-docker:7.4 and this:

I faced a similar problem with php:7.4-fpm-alpine image. It seems like wkhtmltopdf is missing in Alpine v.3.15, but it is available in v.3.14. Try to change FROM php:8-fpm-alpine to FROM php:8-fpm-alpine3.14

sorry, I am confused right now...
but our image in Container Registry in GitLab (with your previous version of 7.4/Dockerfile) is working perfect right now

I will left the issue open for now if someone else faced with same
and maybe will have more description

lorisleiva commented 2 years ago

Oh yeah, I've just found that same StackOverflow post. Weird that they would remove the package after 3.14 but they must have had their reasons. Thanks for raising this issue this might indeed help someone else. :)

wijaksanapanji commented 2 years ago

Thanks for quick reply

oh... true it was installed later in .gitlab-ci.yaml apk add --update-cache ... wkhtmltopdf but this started to throw an error since yesterday

ERROR: unable to select packages: wkhtmltopdf (no such package): required by: world[wkhtmltopdf]

and then I found last merge to lorisleiva/laravel-docker:7.4 and this:

I faced a similar problem with php:7.4-fpm-alpine image. It seems like wkhtmltopdf is missing in Alpine v.3.15, but it is available in v.3.14. Try to change FROM php:8-fpm-alpine to FROM php:8-fpm-alpine3.14

sorry, I am confused right now... but our image in Container Registry in GitLab (with your previous version of 7.4/Dockerfile) is working perfect right now

I will left the issue open for now if someone else faced with same and maybe will have more description

Have you resolved it? I'm having similar problem, I need wkhtmltopdf and wkhtmltoimage

DmitrySidorenkoShim commented 2 years ago

Have you resolved it? I'm having similar problem, I need wkhtmltopdf and wkhtmltoimage

yes, I used previous version of 7.4/Dockerfile and created our image in Container Registry in GitLab since then I didn't touched this topic

you can google it it is in official documentation of GitLab and if you don't use GitLab - you can create your own docker image, publish it and use it for your deployment

I hope it will help

wijaksanapanji commented 2 years ago

I hope it will help

Thanks for the reply, I created my own Dockerfile that use this docker image and copy wkhtmltopdf from this image surnet/alpine-wkhtmltopdf.