search

lorisleiva / laravel-docker

🐳 Generic docker image for Laravel Applications
MIT License
927 stars 313 forks source link

does this support HTTPS - Let's Encrypt? #48

Closed KalanaPerera closed 4 years ago

KalanaPerera commented 4 years ago

Better to have Let's Encrypt

lorisleiva commented 4 years ago

Hi there 👋

I'm not sure I understand the rationale behind using Let's Encrypt on an alpine Docker image?

KalanaPerera commented 4 years ago

Hi,

Thank you for the reply, Why I mentioned Let's Encrypt is then, using this docker image we can host HTTPS-enabled Laravel app easily.

lorisleiva commented 4 years ago

Yes, I understand this but this is an alpine image which does not include php-fpm, nginx or anything that would actually serve your application. Thus, support for HTTPS should be implemented at a different level, e.g. on a different container.

I hope this helps.