search

lorisleiva / laravel-docker

🐳 Generic docker image for Laravel Applications
MIT License
927 stars 313 forks source link

Please update phpcs #54

Closed Synchro closed 4 years ago

Synchro commented 4 years ago

The lorisleiva/laravel-docker:latest image currently includes phpcs 3.5.3. Unfortunately my project is suffering from a phpcs bug that was fixed in 3.5.5 (released 2 weeks ago), and this means that the docker image is currently breaking my build. Could you update it please?

I noticed #46 mentioned using the project's own phpcs - that would fix my issue, but possibly break others.

lorisleiva commented 4 years ago

Fair enough, the images had not been built for a while. Re-building this now. 🙂

Synchro commented 4 years ago

Thank you!

lorisleiva commented 4 years ago

All images have been re-built successfully. Would you please let me know if it fixes this issue?

Synchro commented 4 years ago

Yes, that works perfectly, thanks.