search

lorisleiva / laravel-docker

🐳 Generic docker image for Laravel Applications
MIT License
927 stars 313 forks source link

Add Redis extension #61

Closed fgilio closed 3 years ago

fgilio commented 3 years ago

👋🏼 This should be enough to take care of https://github.com/lorisleiva/laravel-docker/issues/10, according to https://github.com/edbizarro/gitlab-ci-pipeline-php/blob/f8ee01ccb5d35c5449f921844ba16b56b115ea65/php/scripts/extensions.sh#L131-L133

lorisleiva commented 3 years ago

Awesome! Thanks for that @fgilio! 🍺

fgilio commented 3 years ago

🍻

fgilio commented 3 years ago

May be worth noting that this added the Redis extension to PHP, but there's no actual Redis service in the image 🤔

@lorisleiva do you think the issues shouldn't be closed until there's a Redis service? Maybe I'm overthinking this, you can add the service in CI like you add MySQL... Yeah, nevermind

lorisleiva commented 3 years ago

I think so yeah. I don’t think it’s the responsibility of this image to start a redis server but at least now it can interact with one. It’s also worth noting that the predis composer package is back to being maintained so that should make life even easier when it comes to redis. ☺️

fgilio commented 3 years ago

Yes, that's really nice. They're are even already planning/working on PHP 8 compat 🙌