Missing git after commit "Install php extension with `docker-php-extension-installer` + get rid of already installed extension"

lorisleiva / laravel-docker

🐳 Generic docker image for Laravel Applications

MIT License

927 stars 312 forks source link

Missing git after commit "Install php extension with `docker-php-extension-installer` + get rid of already installed extension" #96

Closed RobertGres closed 2 years ago

RobertGres commented 2 years ago

Hi!

Our pipeline relies on your docker image having git executable. However, it seems like after the latest commit it's no longer found and thus everything fails.

Are you sure that those removed dependencies were really "already installed"?

Or should we just install it explicitly in our scripts? (on many projects)

ksassnowski commented 2 years ago

This is most likely a mistake and git should be added back in. I guess our pipeline doesn't depend on git that's why I didn't notice this issue when testing it.

ksassnowski commented 2 years ago

Heads up, I've opened a PR (#97) to install git again in the images.

RobertGres commented 2 years ago

@ksassnowski Thank you!

ksassnowski commented 2 years ago

Maybe we should leave this issue open until the PR has been merged in case other people run across the same problem.

RobertGres commented 2 years ago

True, I thought PR would be accepted faster, and there seem to be other people having troubles with other dependencies as well

michaelhume commented 2 years ago

I ran into #99 and #96 myself today as well.

lorisleiva commented 2 years ago

Sorry guys didn't see all these issues until now. I've merged the git fix.