lorisleiva / solana-core-programs

[WIP] Generated clients for core Solana programs
Other
4 stars 1 forks source link

add BPF version of address lookup table #3

Closed buffalojoec closed 3 months ago

buffalojoec commented 4 months ago

This PR adds the BPF version of the Address Lookup Table program.

For now, I felt like this was a good place to kill two birds with one stone:

Address Lookup Table (BPF)

This BPF implementation essentially replaces the following crates in github.com:solana-labs/solana/programs:

Biggest changes for BPF migration:

Errors

Errors are now inside of the program crate, not solana_sdk.

This was necessary for the following reasons:

We should discuss whether or not to remove the original errors from the SDK and lean on the newly defined ones, or add the new ones necessary to the existing SDK module. Regardless, they will need to be modified to be able to map to ProgramError.

PACKET_DATA_SIZE and limited_deserialize(..)

In this implementation, I added a temporary hack for limited_deserialize until we decide if and how to update the SDK.

We can decide to export this if we want, if other programs also need it and it's useful to on-chain program developers.

2501babe commented 4 months ago

pls add me as a reviewer, will do this next week

lorisleiva commented 4 months ago

@2501babe For some reason I'm only able to add myself as a review on this PR, not sure why. 🙁

2501babe commented 4 months ago

i think you need to invite me as a collaborator https://stackoverflow.com/questions/57946787/cant-add-a-reviewer-for-github-pull-request

lorisleiva commented 4 months ago

Thanks! I've invited you, Joe and Jon. 🙂