search

lorisleiva / solana-wallets-vue

Solana wallet integration for Vue 3
https://solana-wallets-vue-demo.netlify.app/
173 stars 65 forks source link

fix(deps): peerDependencies #23

Closed tiamo closed 2 years ago

netlify[bot] commented 2 years ago

Deploy Preview for solana-wallets-vue-demo ready!

Name Link
Latest commit 689761db6cbc2abfafd2b09f5465a34934574ee2
Latest deploy log https://app.netlify.com/sites/solana-wallets-vue-demo/deploys/62b372c1bdf6e600085298d1
Deploy Preview https://deploy-preview-23--solana-wallets-vue-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

lorisleiva commented 2 years ago

Hey 👋 Do you care to explain why?

tiamo commented 2 years ago

You have already included "@solana/wallet-adapter-wallets": "^0.16.1" to "devDependencies" but pnpm always uses "^0.15" version from the "peerDependencies".

tiamo commented 2 years ago

fixed with "@solana/wallet-adapter-wallets": "^0.15 | ^0.16"

tiamo commented 2 years ago

strange behaviour, new project works well with current peer dependencies

tiamo commented 2 years ago

This PR will be helpful to prevent warnings like this one:

 WARN  Issues with peer dependencies found . └─┬ solana-wallets-vue └── ✕ unmet peer @solana/wallet-adapter-wallets@^0.15: found 0.16.6

lorisleiva commented 2 years ago

Makes sense 🙆‍♂️