lorlor / android-rcs-ims-stack

Automatically exported from code.google.com/p/android-rcs-ims-stack
0 stars 0 forks source link

HTTP based FT in GC requests display notification #249

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
According to BB PDD there should be no display notification request for GC 
messages. Section 7.1.1.1 lists notification "Content Delivered" but section 
7.2.1 does not. This is in compliance with section 6.1.4: Unlike1-to-1 chat, 
see 5.1.3 above, displayed notifications will not be offered, and only 
delivered notifications will be, [...]

Proposal:
In OriginatingHttpGroupFileSharingSession.sendFileTransferInfo() change from 
ChatUtils.buildCpimMessageWithImdn(...) to 
ChatUtils.buildCpimMessageForGroupChat(...). 

Original issue reported on code.google.com by andreas-...@telekom.de on 21 Mar 2014 at 6:40

GoogleCodeExporter commented 8 years ago
The IM Sender should only request for positive delivery notification.

Original comment by lemordan...@gmail.com on 21 Mar 2014 at 7:50

GoogleCodeExporter commented 8 years ago

Original comment by lemordan...@gmail.com on 21 Mar 2014 at 7:54

GoogleCodeExporter commented 8 years ago
revision 502

Original comment by andreas-...@telekom.de on 21 Mar 2014 at 9:54

GoogleCodeExporter commented 8 years ago
The displayed notifications are needed for FToHTTP even if Group chat not use 
them.
The message used for FToHTTP is not managed in the same as other message. 

In terminating side, a delivered and displayed notification will be created 
directly by the stack (in TerminatingHttpFileSharingSession).
In originating side, the delivered and displayed notification are catched to 
call handleFileDeliveryStatus.

Original comment by benoit.j...@gmail.com on 24 Mar 2014 at 9:29

GoogleCodeExporter commented 8 years ago
>>In originating side, the delivered and displayed notification are catched to 
call handleFileDeliveryStatus.
I don't think that displayed notifications are needed for FToHTTP in a GC. Fore 
sure they are needed for a 1-2-1 chat.

Please carefully check the two sections of BB PDD (RCC60):
Section 7.1.1.1 lists notification "Content Delivered" (which uses the IMDN 
"displayed") but section 7.2.1 does not mention this.

>>In terminating side, a delivered and displayed notification will be created 
directly by the stack (in TerminatingHttpFileSharingSession).
There's actually two classes:
TerminatingHttpFileSharingSession and TerminatingHttpGroupFileSharingSession; 
the later one could (and should) handle IMDNs differently.

Original comment by andreas-...@telekom.de on 24 Mar 2014 at 2:29

GoogleCodeExporter commented 8 years ago

Original comment by lemordan...@gmail.com on 7 Apr 2014 at 11:52

GoogleCodeExporter commented 8 years ago

Original comment by lemordan...@gmail.com on 10 Apr 2014 at 3:15