search

lorniu / go-translate

Translator on Emacs. Supports multiple engines such as Google, Bing, deepL, ChatGPT, StarDict, Youdao and so on.
GNU General Public License v3.0
274 stars 37 forks source link

Possibly accidential history rewrite #56

Closed tarsius closed 1 year ago

tarsius commented 1 year ago

Are you aware that you have rewritten all history since v0.1? One consequence of that is that later tags are no longer reachable from a branch.

Same for ox-spectacle.

Ah, I see. You changed your email. You usually shouldn't rewrite history for that. And you don't have to; you could instead add .mailmap. See https://git-scm.com/docs/gitmailmap.

lorniu commented 1 year ago

Oh, sorry, I just want to correct my messy email addresses. Thanks for the reminder.

tarsius commented 1 year ago

Are you going to revert the rewrite or stick to it? Either one is fine, but if you tell me, I can avoid having to twice intervene manually when updating these packages on the Emacsmirror. If you stick to the rewrite, then you should also update the tags.

lorniu commented 1 year ago

I have updated the tags. Stick to the rewrite please.

tarsius commented 1 year ago

Thanks!

tarsius commented 1 year ago

I have updated the tags.

I think you forgot to (force) push them.

lorniu commented 1 year ago

Isn't that push like this?

git push origin --tags --force

I haved pushed like that and tag links in github is reachable (for example: v0.4).

tarsius commented 1 year ago

Yes, the tags are there. Sorry for the noise.