search

lorniu / go-translate

Translator on Emacs. Supports multiple engines such as Google, Bing, deepL, ChatGPT, StarDict, Youdao and so on.
GNU General Public License v3.0
274 stars 37 forks source link

[Feature] make gt-posframe-pop-render frame customizable #69

Closed seagle0128 closed 3 months ago

seagle0128 commented 3 months ago

Now gt-posframe-pop-render frame is not customizable for frame parameters, e.g. border. I'd like make it like below.

I can make a PR if you will.

image

lorniu commented 3 months ago

Do the commit in the improve-posframe-render branch meet the needs? Suggestions please.

Usage example:

(gt-posframe-pin-render :frame-params (list :border-width 40 :border-color "red"))
seagle0128 commented 3 months ago

Do the commit in the improve-posframe-render branch meet the needs? Suggestions please.

The branch did work well for me.

lorniu commented 3 months ago

Merged. The slot is renamed to frame-params.

seagle0128 commented 3 months ago

It seems it hasn't been released to melpa yet.