lorserker / ben

a game engine for bridge
GNU General Public License v3.0
41 stars 30 forks source link

Error in Bidding_Binary.py #49

Closed ThorvaldAagaard closed 1 year ago

ThorvaldAagaard commented 1 year ago

I am no expert on python, but image is only updating 1 in 10.000 deals as training

And when you look at it will you add a note why you are using 32 as number of cards? image

Reading the code it seems you are grouping cards from 7-2 in one group, and that seems like a good idea, but I think it is very few bidding systems that adds value to 8 and 9, so why not reduce the deck to 24?

lorserker commented 1 year ago

yes, the indentation looks wrong.

32 is quite arbitrary. for bidding it could be less, for play it probably should be more :)

ThorvaldAagaard commented 1 year ago

Solved in #57