lorserker / ben

a game engine for bridge
GNU General Public License v3.0
41 stars 30 forks source link

Updated links to Bridge Bidding Analyzer #50

Closed ThorvaldAagaard closed 1 year ago

ThorvaldAagaard commented 1 year ago

Edward has changed the structure of his site, and I have updated the links accordingly

ThorvaldAagaard commented 1 year ago

OK, I thought, that I could commit in small chunks, and then create a merge based on each commit, but it looks like this pull request gets updated with my commits, But I will still try to keep, the small commits, so it is easier to see, what and why the change was made

lorserker commented 1 year ago

@ThorvaldAagaard thank you for your PR! sorry for the long delay in reviewing. i think that we are almost ready to merge, i just had 2-3 questions.

lorserker commented 1 year ago

@ThorvaldAagaard i remembered something. now that the bots parameters changed slightly, i am wondering whether the table_manager_client still works. have you checked that? https://github.com/lorserker/ben#play-against-itself-and-against-other-bots (now i wish i hadn't copy-pasted the code from game.py when i implemented it :))

ThorvaldAagaard commented 1 year ago

Table_manager_client should work, but as I have used it a lot for testing, I have a lot of changes for that in the next version.

lorserker commented 1 year ago

ok, thanks! 👍 then please ping me when you are ready to merge.

ThorvaldAagaard commented 1 year ago

I recommend you merge this and I make a new PR as the changes in the next version is impacting a lot of files.

On the other hand I hope to finish my testing during the weekend, so feel free to wait.

ThorvaldAagaard commented 1 year ago

I have now updated with all my changes, so there is some work for you to review.

I have checked that all is working, but there might be things I have missed,

lorserker commented 1 year ago

@ThorvaldAagaard merging. thanks!

please let me know when we are ready to bump the version

ThorvaldAagaard commented 1 year ago

I think it is fine to create version 0.0.2 based on this merge. Perhaps we can get Eamon to test the version.