search

loryjs / lory

☀ Touch enabled minimalistic slider written in vanilla JavaScript.
http://loryjs.github.io/lory/
MIT License
2.28k stars 243 forks source link

Bugfix/support passive #715

Closed jacobjuul closed 6 years ago

jacobjuul commented 6 years ago

Fixes issue #709

heinrichson commented 6 years ago

Lets get this for improved scrolling performance

praneybehl commented 6 years ago

Can this pull request be merged? The browser console keeps throwing Violation warnings and they also reflect on google analytics

image

s3rgiosan commented 6 years ago

@jacobjuul can you update the dist files in your branch? I want to use your fix via npm.

jacobjuul commented 6 years ago

@s3rgiosan updated, please let me know how it works out for you.

s3rgiosan commented 6 years ago

@jacobjuul worked like a charm. Thanks 👍

Saturate commented 6 years ago

@meandmax this looks good to merge, it could seem that you are busy. Do you need some help maintaining this repo?

meandmax commented 6 years ago

@Saturate added you to contributors, thanks for offering help!

meandmax commented 6 years ago

For future pull-requests please keep in mind that the deployment won`t work if the commit messages are not in the right format.

Check this out: http://commitizen.github.io/cz-cli/

jacobjuul commented 6 years ago

@meandmax I'd be happy to help as well