Closed MrSlide closed 6 years ago
Hey @MrSlide thanks for the PR! Unfortunately there are some conflicts, due to other updates that must be fixed. It seems like all that's needed is a new build , but none the less it's needed.
Thanks!
Hi @Saturate I just resolved all the conflicts
Hi @MrSlide it still conflicts for me :-(
@Saturate I fixed the merge conflicts again, only the dist files are conflicting, this will happen every time something is merged with the master branch but can easily be fixed by just creating a new build.
I merge this now, but again need to add an empty trigger commit to the master to trigger a build. Please keep in mind that if you do your commits use either https://github.com/commitizen/cz-cli or just do it manually. Check out this: https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#commits
cheers
When using Lory in applications that use server side rendering (SSR), like Vue.js or React applications, rendering the applications fails due to Lory trying to use the
window
object.This fix checks that
window
is defined, and if not, usesnull
as the default value forwindow
.