loserMcloser / waylogout

MIT License
35 stars 2 forks source link

Deprecated wlroots protocol #16

Closed Disco-Robot closed 1 week ago

Disco-Robot commented 11 months ago

Before anything thx for the awesome project !!! After an update waylogout stopped working due to a deprecated protocol from wlroots

2023-12-08 21:25:46 - [main.c:1729] Compositor does not support the input inhibitor protocol, refusing to run insecurely

I searched a bit and it looks like the previous implementation was replaced by this one. Since the project is inspired by swaylock-effects and oblogout this issue might be relevant too.

I will try to take a look into it, but I don't know much about wlroots, if I manage to do anything will do a pull request.

loserMcloser commented 11 months ago

Hmm, OK. I'm still on wlroots 0.17 on Archlinux, so I haven't experienced this issue yet. I guess you're using a wlroots-git type of package on your distro? I'll try to see if I can get sway-git-wlroots-git temporarily installed to test it out.

Disco-Robot commented 10 months ago

Ok that's odd, I running probably a similar setup to yours since I am also running arch (btw) with the git package, my wlroots actually was on version behind too due to dependency from swayfx tested with hyprland and wlroots 17.0 and still got the same error.

This is the debug output running my current config

2023-12-15 02:51:50 - [main.c:1671] Found config at .config/waylogout/dark
2023-12-15 02:51:50 - [main.c:1585] Config Line #1: hide-cancel
2023-12-15 02:51:50 - [main.c:1585] Config Line #2: screenshots
2023-12-15 02:51:50 - [main.c:1585] Config Line #3: font="Baloo 2"
2023-12-15 02:51:50 - [main.c:1585] Config Line #4: effect-blur=7x5
2023-12-15 02:51:50 - [main.c:1585] Config Line #5: indicator-thickness=20
2023-12-15 02:51:50 - [main.c:1585] Config Line #6: ring-color=4c566aaa
2023-12-15 02:51:50 - [main.c:1585] Config Line #7: inside-color=4c566a66
2023-12-15 02:51:50 - [main.c:1585] Config Line #8: text-color=#2e3440aa
2023-12-15 02:51:50 - [main.c:1585] Config Line #9: line-color=00000000
2023-12-15 02:51:50 - [main.c:1585] Config Line #10: ring-selection-color=4c566aaa
2023-12-15 02:51:50 - [main.c:1585] Config Line #11: inside-selection-color=4c566a66
2023-12-15 02:51:50 - [main.c:1585] Config Line #12: text-selection-color=eaeaeaaa
2023-12-15 02:51:50 - [main.c:1585] Config Line #13: line-selection-color=00000000
2023-12-15 02:51:50 - [main.c:1585] Config Line #14: poweroff-command="poweroff"
2023-12-15 02:51:50 - [main.c:905] Action power off:  
  symbol  
  command poweroff
2023-12-15 02:51:50 - [main.c:1585] Config Line #15: reboot-command="reboot"
2023-12-15 02:51:50 - [main.c:905] Action reboot:  
  symbol  
  command reboot
2023-12-15 02:51:50 - [main.c:1585] Config Line #16: suspend-command="systemctl suspend;swaylock --config $HOME/.config/swaylock/$(grep -oP '(?<=^export CURRENT_THEME=).*' ~/.bash_profile)"
2023-12-15 02:51:50 - [main.c:905] Action sleep:  
  symbol  
  command systemctl suspend;swaylock --config $HOME/.config/swaylock/$(grep -oP '(?<=^export CURRENT_THEME=).*' ~/.bash_profile)
2023-12-15 02:51:50 - [main.c:1585] Config Line #17: logout-command="hyprctl dispatch exit"
2023-12-15 02:51:50 - [main.c:905] Action logout:  
  symbol  
  command hyprctl dispatch exit
2023-12-15 02:51:50 - [main.c:1585] Config Line #18: selection-label
2023-12-15 02:51:50 - [main.c:1681] Parsing CLI Args
2023-12-15 02:51:50 - [main.c:1700] Found 4 configured actions
2023-12-15 02:51:50 - [main.c:939] No default action configured
2023-12-15 02:51:50 - [main.c:1729] Compositor does not support the input inhibitor protocol, refusing to run insecurely

Not much is added on top off the error, and this are the dependencies versions

rep -E "Name|Version" 
Name            : libxkbcommon
Version         : 1.6.0-1
Name            : wlroots
Version         : 0.17.0-1
Name            : cairo
Version         : 1.18.0-1
Name            : gdk-pixbuf2
Version         : 2.42.10-2
Name            : otf-font-awesome
Version         : 6.5.1-1
Name            : wayland
Version         : 1.22.0-1

I pointed out the deprecated protocol because that seemed the issue, but maybe there is something else, will try to pop out a VM to see if this issue still remains, I could also help you out with some headers and tips, though I am still a bit noob in programming overall and on the wlroots protocols.

Palladinium commented 1 week ago

Also running Arch (and Sway). Did a system update yesterday and now I'm encountering this issue for the first time. It's not clear to me what changed that could have caused that, as I didn't keep track of whether wlroots updated - I am on 0.18 right now though, and the packaging date suggests it's quite recent (~ two weeks ago), so that could be the culprit.

loserMcloser commented 1 week ago

Yeah, finally ran into this today too. sway updated to v1.10 so probably it finally dropped support for that old protocol. I'm going to fix my fork of swaylock-effects first (old fork, same issue) and then I'll get on fixing things here.