search

loskutov / deadbeef-lyricbar

A simple plugin for DeaDBeeF audio player that fetches and shows the song’s lyrics
MIT License
29 stars 8 forks source link

Support for more lyrics sites than just lyrics.wikia.com #5

Closed C0rn3j closed 5 years ago

C0rn3j commented 5 years ago

I see 

static const ustring LW_FMT = "http://lyrics.wikia.com/api.php?action=lyrics&fmt=xml&artist=%1&song=%2";

in the code and not much else. I recall other plugins (maybe even your infobar?) for lyrics I tried today have support for multiple sites, including infobar.

Would it also be possible to add the used lyrics APIs/sites to the README so people don't have to go digging in the source for it?

Thanks!

loskutov commented 5 years ago

Unfortunately, I currently don't have much time to add new features, and also it seems to me that the right way of downloading lyrics is using some dedicated tool and saving them to track metadata (e.g. beets has a plugin for that) instead of re-implementing the API-interaction logic in each and every player or lyrics displaying plugin. I'd recommend this approach if you're having troubles with finding lyrics for some tracks, no matter what you use to display them at the end of the day.

C0rn3j commented 5 years ago

Unfortunately, I currently don't have much time to add new features

That's a shame. I forked the project and added Open Lyrics Database as a source, and did some other small tidbits.

What I can't figure out however is to how to package the project for Arch Linux, I get a successful build but loading the plugin in deadbeef fails. I checked the working vs non-working .so files via ldd and they seemed to have the same dependencies, so I don't know what's going wrong.

Would you have any idea about that?

PKGBUILD: https://haste.rys.pw/raw/renodaqalo extra-x86_64-build: https://haste.rys.pw/raw/ijiqapiniy deadbeef error: https://haste.rys.pw/raw/ufumusewal

loskutov commented 5 years ago

Actually my Makefile doesn't work well when you do make gtk2 && make gtk3: it uses the same object files, leading to link-errors. You could add make clean as a hotfix or switch to something more advanced than my Makefile (see CMakeLists.txt @38f87, I dropped it to reduce dependencies number but perhaps it wasn't a brilliant idea)