search

losnoco / Cog

Cog - A Free and Open Source Audio Player for macOS 10.13+
https://cog.losno.co
GNU General Public License v2.0
695 stars 45 forks source link

Crash when changing file associations #361

Closed grishka closed 1 year ago

grishka commented 1 year ago

Describe Cog crashes when files are associated with it while it's running. Sometimes it also crashes just on its own with the same stack trace.

To Reproduce (delete if not applicable) There are probably other ways to reproduce this but here's what does it reliably for me:

  1. Make a folder with two audio files of different types (I did it with tracker modules, but it'd probably work with anything else too)
  2. Make sure Cog is closed
  3. Associate one file type with Cog through the Finder properties window as shown in the video below
  4. Open this file, Cog launches
  5. Associate the second file type with Cog
  6. Watch it crash

Expected behavior It shouldn't crash, obviously :)

Screenshots Screencast of me reproducing the crash: https://disk.yandex.ru/i/deg8m5nvb-Iczw

**Version information:***

Additional context Complete crash log: Cog-2023-06-03-190102.txt

kode54 commented 1 year ago

Wow, I had no idea that file type association changing started notifying the app of anything. I'll have to debug this.

kode54 commented 1 year ago

Would you mind consenting to the Firebase Crashlytics submission in Preferences, then trying to reproduce the crash? I can't make Xcode symbolicate the crash log you posted, and I can't reproduce the issue locally, either.

OH! Maybe you're doing the permission change on a folder that's added to the sidebar folder browser in the app? I'll have to check that.

Edit 2: Yeah, that did it. I reproduced the crash. I'll have to diagnose this.