search

losnoco / Cog

Cog - A Free and Open Source Audio Player for macOS 10.13+
https://cog.losno.co
GNU General Public License v2.0
695 stars 45 forks source link

DSD playback is staticky unless DSD_DECIMATE is disabled #367

Closed bmastenbrook closed 1 year ago

bmastenbrook commented 1 year ago

Describe DSD playback is staticky unless DSD_DECIMATE is redefined to 0 in ChunkList.h. If DSD_DECIMATE is defined to 0, output level drops to "SACD 0dB" (aka -6dB) as expected, but output quality is good.

To Reproduce (delete if not applicable) Steps to reproduce the behavior:

  1. Obtain a DSD file. The files I'm using are DSD64. You can obtain a DSD64 sample from NativeDSD at no cost.
  2. Play the file.

Expected behavior

Playback should be free of static or other artifacts.

**Version information:***

bmastenbrook commented 1 year ago

Confirmed, this is fixed now. I suppose audio is still at -6dB compared to PCM; I've opened #368 as a feature request related to this.

kode54 commented 1 year ago

It's really not -6 dB compared to PCM. The filter the decimator uses has a +6 dB gain anyway, which is why I correct it on output.