losnoco / Cog

Cog - A Free and Open Source Audio Player for macOS 10.13+
https://cog.losno.co
GNU General Public License v2.0
695 stars 45 forks source link

Crash when advancing songs multiple times quickly #377

Open nyanpasu64 opened 1 year ago

nyanpasu64 commented 1 year ago

Describe When I use Command+Left/Right to switch songs many times quickly, Cog crashes.

To Reproduce (delete if not applicable) Steps to reproduce the behavior:

  1. Download https://forums.serenesforest.net/index.php?/topic/55242-fire-emblem-if-soundtracks-voice-clips-etc/.
  2. Import all songs (or any subfolder) into Cog.
  3. Begin playing a song.
  4. Press Command+Left/Right 2 or more times.

macOS crash report: https://gist.github.com/nyanpasu64/d048522026039e4a8298254e14889a69

Expected behavior No crash, intermediate song loads are cancelled and final selected song plays.

Screenshots

Screenshot 2023-09-21 at 12 48 48 AM

**Version information:***

Additional context Add any other context about the issue here.

kode54 commented 1 year ago

This should be fixed now.

nyanpasu64 commented 1 year ago

Tried the latest Cog Version 2846 (2846-gf52de150). If I hit Command-Right 2 times in a row it works (although the play icon jumps around a bit in the list). If I press it 4-5 or more times quickly, it enters a state where and all songs fail to play and advance to the next song every few seconds (either immediately, or playback stops and this error occurs when I resume playback). One time Cog beachballed instead.

(I'm mostly using mpd on a spare laptop hooked up to room speakers, with game audio files pre-converted to .flac, to play music now. But I can still test this bug to see if it's fixed.)