losnoco / Cog

Cog - A Free and Open Source Audio Player for macOS 10.13+
https://cog.losno.co
GNU General Public License v2.0
695 stars 45 forks source link

Opus format files no longer show tags when using CoreAudioDecoder #403

Open faxx1080 opened 1 month ago

faxx1080 commented 1 month ago

Describe I noticed file tags (Artist, album, etc) don't show up with opus files anymore. I tracked this down to PluginController.m:audioDecoderForSource and metadataForURL.

This code restores old behavior:

          if(  ([[_decoders objectAtIndex:i] isEqualToString:@"CoreAudioDecoder"])
             && ( [ext isEqual:@"opus"] || [ext isEqual:@"OPUS"] )   ) {
            DLog(@"PATCH: Removing CoreAudioDecoder for opus - this is for playing not metadata");
            [_decoders removeObjectAtIndex:i];

To Reproduce (delete if not applicable) Steps to reproduce the behavior:

  1. Add an opus file
  2. Tags don't show up.

Expected behavior Tags should show up.

**Version information:***

Additional context I believe a recent macOS update (14.6) may have added CoreAudioDecoder for opus files, causing this to happen.

kode54 commented 1 month ago

Feel free to adjust this to a lower priority instead:

https://github.com/losnoco/Cog/blob/main/Plugins/CoreAudio/CoreAudioDecoder.m#L378