losso3000 / coppenheimer

An alternative UI for vAmigaWeb with realtime memory inspection
https://vamigaweb.github.io/doc/about.html
GNU General Public License v3.0
6 stars 0 forks source link

memory issue on startup in some browsers #2

Closed losso3000 closed 5 months ago

losso3000 commented 5 months ago

(Moved from discussions, as project issues were not activated yet, see discussion entry https://github.com/losso3000/coppenheimer/discussions/1 by @mithrendal)

JavaScript error on fresh start, esp. when clicking "Install AROS ROMs", in memimage_data.data.set(memdump_buffer). Confirmed by another independent bug report.

I finally managed to reproduce this issue with Edge under Windows 11 when using a custom system-wide display scale setting of 117 (probably happens with other "odd" values as well). So this seems to be related with DPI/pixel calculations; setting the canvas size to fill the window uses some (hacky) DOM element pixel calculations that might end up in fractional values and break the assumption that MEM_HPIXELS/MEM_VPIXELS are always integer values.

losso3000 commented 5 months ago

Live on https://coppenheimer.heckmeck.de/ (0.1.0-alpha3) with commit fc70489a52b28549208ce7b943e29005a9a659c3 which fixes this issue for me; needs confirmation

mithrendal commented 5 months ago

retested on browsers that were previously exhibiting the problem

Very nice - good job ! 😎

losso3000 commented 5 months ago

Thanks for the instant QA!

losso3000 commented 5 months ago

Closing this, then. Yay 🙂