lost-university / web

https://lost.university
5 stars 2 forks source link

Use new data #15

Closed StefanieJaeger closed 1 year ago

StefanieJaeger commented 1 year ago

I included the fix from #13 and fixed the problem, that navigating to an url with an old module would result in an empty plan.

StefanieJaeger commented 1 year ago

Following things have been tested:

StefanieJaeger commented 1 year ago

@Mafii or @jeremystucki could you test this PR with the above checklist and maybe some fuzzy testing?

Mafii commented 1 year ago

With this, my Italian is suddenly 0 ects - which is wrong imo. It is permitted to have 4 ects totally free of choice no matter the category - what's happening here?

image

Current live-version:

image

Mafii commented 1 year ago

Looks good to me otherwise @StefanieJaeger !

StefanieJaeger commented 1 year ago

With this, my Italian is suddenly 0 ects - which is wrong imo. It is permitted to have 4 ects totally free of choice no matter the category - what's happening here?

I fixed this in https://github.com/lost-university/data/pull/3.

StefanieJaeger commented 1 year ago

I'll wait with merging this PR until after the 2nd phase of the "Stundenplananmeldung" is over. Just in case.