Use vite over webpack - Githubissues

lost-university / web

https://lost.university

5 stars 3 forks source link

Use vite over webpack #16

Closed Mafii closed 1 year ago

Mafii commented 1 year ago

Partially solves #11

[x] Use vite (this allows using newer node versions and faster development)
[x] Use newer versions of packages
[x] Re-add linters and git hooks
[x] Decide if we want lint on run dev (otherwise drop the last commit again)
[x] Verify everything works correctly

StefanieJaeger commented 1 year ago

If @jeremystucki is busy, maybe I could do the review?

Mafii commented 1 year ago

@jeremystucki PRs currently don't run actions, you might have to activate that?

jeremystucki commented 1 year ago

There is actually no CI configured except for the deployment. I'll have a look in the next few days and set something up.

Edit: I did it now, please update your branch.

Mafii commented 1 year ago

Just checked, "works on my machine" ;)

jeremystucki commented 1 year ago

@StefanieJaeger please also test locally @Mafii please resolve all open conversations

Can one of you also test the release build?

StefanieJaeger commented 1 year ago

I tested it locally. Plans, categories, modules and focuses all seem to work. Selecting a default plan does not save it in cache, you'd first have to change your module selection. I think, default plans should be cached as well. But I have a fix in another PR for that, so no biggie.

Mafii commented 1 year ago

@jeremystucki can I merge? (You can too, don't care)

jeremystucki commented 1 year ago

👍

On Tue, May 9, 2023 at 16:37, Mathias Fischler @.***(mailto:On Tue, May 9, 2023 at 16:37, Mathias Fischler < wrote:

@.***(https://github.com/jeremystucki) can I merge?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>