lostb1t / replex

Remix your Plex hubs
204 stars 7 forks source link

feat: override include_watched w/ collection label #107

Closed luukleenders closed 9 months ago

luukleenders commented 9 months ago

feat: override include_watched w/ collection label

feat: change include_watched to exclude_watched

lostb1t commented 9 months ago

thanks for this. Ill have look at the code this weekend.

One thing is that the naming doesnt make sense anymore (thats my fault). Plex default is include and replex removes that. And adding REPLEX_INCLUDE_WATCHED as a label to exclude watched makes it even weirder.

So might be a good time to invert this and replace REPLEX_INCLUDE_WATCHED with REPLEX_EXCLUDE_WATCHED (default value set to false for global env) for both the global setting and the collection label

Could you also change the readme for this and info for the new label?

luukleenders commented 9 months ago

The name change makes sense, I've changed include to exclude - not sure if I did the 250 limit thing right though. Also updated the readme :)

luukleenders commented 9 months ago

I've tried to put pagination back but I should probably dive into how pagination actually works.

With REPLEX_EXCLUDE_WATCHED=0 I get a maximum of 50 items back but the Plex ui won't load more when I scroll (my assumption is that it should?). With REPLEX_EXCLUDE_WATCHED=1 I get my entire collection back at once.

Maybe I'm also just missing some context of different clients though, all I've tested on so far is the Plex web app.

lostb1t commented 9 months ago

Pagination across clients is messy. Never got it right.

the gist is that when watched is excluded pagination wont work. So replex returns the max of 250 per media type to counter that a little bit.

When watched is included pagination should work. But in practice the clients are finniky. I think it doesn't work in the main branch properly either so this should be ok.

lostb1t commented 9 months ago

@luukleenders pagination in default_transform should be put back again aswell

luukleenders commented 9 months ago

Whoops, missed the default_transform - added it back.

lostb1t commented 9 months ago

top, nogmaals dank hiervoor. Push gelijk een nieuwe release.

lostb1t commented 9 months ago

:tada: This PR is included in version 0.20.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

luukleenders commented 9 months ago

top, nogmaals dank hiervoor. Push gelijk een nieuwe release.

Oh NL haha nice!

Maar graag gedaan, was leuk om in te duiken en ik heb er zelf ook wat aan natuurlijk. Het is sowieso een hele mooie toevoeging aan Plex - als je nog andere puten hebt waar ik zou kunnen helpen dan laat maar weten :)