search

lostcarpark / conclar

ConClár Programme Guide in ReactJS
MIT License
11 stars 12 forks source link

Require http/https on participant links. #104

Closed lostcarpark closed 2 years ago

lostcarpark commented 2 years ago

Fix an issue that links without protocol were interpreted as local links. Fix is to not display links unless protocol included.

mcdemarco commented 2 years ago

This seems a bit harsh, considering that local links are generated by the software, and participant links can easily be identified and prepended with // if they're ambiguous.

lostcarpark commented 2 years ago

Maybe. Not sure if it's clear that this relates to participant links to personal websites and social media sites. I intend to review this later, as I'd like links like Twitter to accept a twitter handle in place of a full URL. However, for Chicon we expect all links will be prefixed with http or https, so I feel we can expand the options later.