lostdesign / linked

🧾 Daily journaling without distraction. An easy, distraction-free way to record your thoughts, declutter your mind and keep the things you want to remember. Join the discord at https://discord.gg/uNjJzZvccr
https://uselinked.com
GNU General Public License v3.0
898 stars 67 forks source link

🐛 Dependency error after initial package install on serving - fs.existsSync is not a function #94

Closed richardevcom closed 3 years ago

richardevcom commented 3 years ago

Describe the bug Getting fs.existsSync is not a function after initial setup via yarn.

To Reproduce Steps to reproduce the behavior:

  1. Clone repository
  2. Run yarn to setup dependecies
  3. Run yarn serve
  4. Get whitescreen and see error in console

Expected behavior Run app without an error.

Desktop (please complete the following information):

Additional context Some people mention that this issue may be due to Visual Code IDE automatically add in dependecies, but I can't demonstrate that it is the same case here.

richardevcom commented 3 years ago

Nevermind. It happens on older node.js (v14 for example). Installed v16 (current stable) ‼️ Just in case I switched from yarn to npm, then I had to reinstall vue-cli globaly and run install with --legacy-peer-deps argument for it to work.

Ngl, I still think this should be checked out tested, since I'm sure I won't be the only one in future having this dependency issue.

PS C:\Users\richa\Projects\dev\linked> npm install --save --legacy-peer-deps
npm WARN deprecated @hapi/bourne@1.3.2: This version has been deprecated and is no longer supported or maintained
npm WARN deprecated @hapi/topo@3.1.6: This version has been deprecated and is no longer supported or maintained
npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated @hapi/address@2.1.4: Moved to 'npm install @sideway/address'
npm WARN deprecated xmldom@0.1.31: Deprecated due to CVE-2021-21366 resolved in 0.5.0
npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
r details.
npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated eslint-loader@2.2.1: This loader has been deprecated. Please use eslint-webpack-plugin
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated querystring@0.2.0: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
npm WARN deprecated phantomjs-prebuilt@2.1.16: this package is now deprecated
npm WARN deprecated html-webpack-plugin@3.2.0: 3.x is no longer supported
npm WARN deprecated @hapi/hoek@8.5.1: This version has been deprecated and is no longer supported or maintained
npm WARN deprecated @hapi/joi@15.1.1: Switch to 'npm install joi'
npm WARN deprecated babel-eslint@10.1.0: babel-eslint is now @babel/eslint-parser. This package will no longer receive updates.
npm WARN deprecated chokidar@2.1.8: Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
npm WARN deprecated chokidar@2.1.8: Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
npm WARN deprecated @sentry/apm@5.21.4: Please migrate to @sentry/tracing; see: https://www.npmjs.com/package/@sentry/apm

> linked@1.3.5 postinstall
> electron-builder install-app-deps

  • electron-builder  version=22.11.4

added 1950 packages, and audited 1951 packages in 4m

128 packages are looking for funding
  run `npm fund` for details

29 vulnerabilities (6 low, 20 moderate, 3 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues possible (including breaking changes), run:
  npm audit fix --force

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.
lostdesign commented 3 years ago

1) About the steps you did:

Clone repository Run yarn to setup dependecies Run yarn serve Get whitescreen and see error in console

This is not the right way to build/serve the app. The right command is yarn electron:serve as per readme https://github.com/lostdesign/linked#contributing

2) Unsure what you mean by missing dependencies? If the right node version (readme, tldr: atleast node 16) is used, the project will start and build just fine.

richardevcom commented 3 years ago

Yes. I understood it after I tried rebuild everything (so I closed the issue since It was my or wind fault). But the v16 of node.js fixed most dependecy issues. and the rest steps + yarn build:all. Visual errors are still there tho.