search

lostenderman / markdown

:notebook_with_decorative_cover: A package for converting and rendering markdown documents in TeX
http://ctan.org/pkg/markdown
LaTeX Project Public License v1.3c
1 stars 0 forks source link

Auto identifiers extensions #153

Closed lostenderman closed 11 months ago

lostenderman commented 1 year ago

Adds:

Fixes:

lostenderman commented 1 year ago

It seems that pdftex and luatex commands give different results regarding spacing when running the plain format:

Example (two spaces between the letters):

# a  b

pdftex:

headingOne: a b

luatex:

headingOne: a  b

Problem present on the main branch, but not on the commonmark one.

Investigating further...

lostenderman commented 1 year ago

First problematic commit is 45570939db76be6dcc18b12d9b23b7839d590413.

Witiko commented 1 year ago

Interesting. On the first glance, disabling eager cache should have no effect whatsoever, because LuaTeX and pdfTeX runs in different temporary directories, so their caches / lack thereof should not interfere. I won't be able to investigate until later in July / early August, but I wonder why the unit tests would pass on the main branch and not here?

lostenderman commented 1 year ago

Is pdfTeX used to test unit tests on the main branch, in the last few runs I only see LuaTeX being used.

Witiko commented 1 year ago

At this point, only LuaTeX is used both on the main branch nor in PRs. Therefore, I don't see why the main branch would be green, whereas this PR is failing the CI.

lostenderman commented 1 year ago

It should now be fixed to pass LuaTeX (which works as expected). The tests still needed a bit of fixing. Just the pdfTeX behaviour surprised me.

Witiko commented 1 year ago

The current state of unit tests, where we only run LuaTeX, is a temporary solution to prevent the timeout of the CI service after merging the commonmark branch in https://github.com/Witiko/markdown/pull/226, which introduced 652 new unit tests. Before releasing 3.0.0-stable in the next couple of months, we will want to speed up the tests, see https://github.com/Witiko/markdown/issues/245. Afterwards, we will need to fix any regressions in formats other than LuaTeX that we have missed due to the partial testing. Therefore, this is an important discovery, although it is not necessary to solve it in this PR.