Closed legomushroom closed 4 years ago
this is very cool. I think I need to review once more to be able to grok through the whole pr. right now I'm wondering if we can make this feature easier to get started/discover. using git info to start broadcasts is compelling - it makes sessions integrated to a natural workflow, which is great. however, the link of a branch to a broadcast is not very natural, and this might just be me. maybe its more natural if we think of the "code review" session type? would love to get your ideas as I'm thinking this through.
@arjun27 the mechanic I want to try out is to provide the means for the user to create a LS session trigger for the future that requires a habit otherwise. Hence every time they start working on some feature, their workspace is automatically shared, creating a "join" trigger for others (given we have a good notification system, session planning and the ability to follow other users).
The idea in general is:
Overall I want to try out this flow when you develop "in the spotlight" where you constantly post updates about your work and give others the opportunity to participate.
The PR:
Branch Broadcasts
The Branch Broadcasts is the mechanic that can tap into existing user workflow, providing the easy way to automatically share the feature branch they are working on, to a Space. After registering a branch for broadcast, every time a user switches to the branch the LiveShare will broadcast the branch to their space. Likewise, when the branch is no longer active, the Live Share stops broadcasting the branch.
That is the first step in implementing the full feature, further planned:
Appreciate your feedback 🙃