lostintangent / spaces

Discover, share, and connect with developers across your favorite teams, classrooms and communities
https://aka.ms/vsls-spaces
MIT License
34 stars 3 forks source link

Overly prescriptive JWT ISS constraint (microsoft login) #121

Closed edwardbrowncross closed 4 years ago

edwardbrowncross commented 4 years ago

Having established that I am unable to log in via github login (#120) I have now been trying to use a Microsoft login. This has not gone well.

When I go to log in using the Live Share extension of VS Code, it opens a Microsoft login window. When I complete this login, it grants me a login.microsoftonline.com JWT, not a vsengsaas.visualstudio.com (the code refers to this as AAD, rather than cascade).

The 'AAD' auth checks that the tenant id is 72f988bf-86f1-41af-91ab-2d7cd011db47. This appears to be the tenant id for microsoft.com. I have three microsoft logins available to me: a hotmail.com, an outlook.com and my work email address. These all have different tenant ids and so spaces will not accept that I am logged in.

Given that Live Share does not require a specific domain for your Microsoft login, why does Live Share Spaces require a microsoft.com login?