Closed legomushroom closed 5 years ago
looks awesome! would we want auth on the websocket?
also, couple of very minor things
@arjun27 @lostintangent added the Cascade token validation, now the user will be able to use any (ms/gh) account thru live share. Also addressed some feedback please take a look.
Re the WS auth, what are we using the WS for at the moment?
Re the WS auth, what are we using the WS for at the moment?
We're using the websocket transport that comes with cowboy (webserver for elixir) – cowboy is also listening for http. We could de-prioritize gating on websocket, at least till we implement private communities (#45)
Code for websocket, on the service, in case you want to review: https://github.com/vsls-contrib/communities/blob/master/service/lib/communities/websocket.ex
@arjun27 ya, but what scenarios we are using the WS for?
what scenarios we are using the WS for?
The websocket delivers real-time updates for: changes to the communities the user is a member of (member added/removed, founder changed), and new requests and messages in these communities
@arjun27 I see, thanks. Sounds like we do want to restrict those also. Maybe not in this PR though.
@vs/vscode-account
module for authentication to share the access tokens with Live Share.Still waits on: