search

lostintangent / spaces

Discover, share, and connect with developers across your favorite teams, classrooms and communities
https://aka.ms/vsls-spaces
MIT License
34 stars 3 forks source link

Load profile pic from the connected live share account #83

Closed RandomFractals closed 5 years ago

RandomFractals commented 5 years ago

in my case it was my github account. Happy to see you pulled profile name as defined there instead of just github handle.

would be nice to have the profile pic loaded automatically in chat too:

vsls-data-community

RandomFractals commented 5 years ago

so, I just found 29 settings for vsls, still no way to set my profile pic.

@arjun27 what am I missing beyond you'll add it from github in your next rev.

somehow you & @lostintangent have your custom icons in that chat :(

vsls-profile-pic-setting

arjunattam commented 5 years ago

The icons in the chat are being pulled from Gravatar right now - and we created the issue to add support to GitHub avatars.

Live Share profiles reuse avatars associated with GitHub or Azure Active Directory accounts. To get the consistency in the chat, we would get to AAD support (pref after GitHub is supported).

Feel free to submit PRs to chat in case you'd like to see this getting prioritized sooner :)

The relevant code is at https://github.com/vsls-contrib/chat/blob/3c88482ceedd928f5e203c905cbff7a9d521cd30/src/vslsCommunities/index.ts#L126

RandomFractals commented 5 years ago

nah! this is good for now. thanks!

RandomFractals commented 5 years ago

not to nit pick but would be nice if you could capture dev's pic, motto & profile link on 'member hover' like I do it in this js notebook User Info section: ...

https://observablehq.com/@randomfractals/notebook-info

|| how overservable does it on top. I like that ;)

RandomFractals commented 5 years ago

@arjun27 not sure this is your final, but I think you can expend on that hover...

vsls-member-hover

RandomFractals commented 5 years ago

feel free to split & log that last issue in this repo || chat.

I'm gonna give you guys some rest for a bit to work out those remote data loads ;)

cheers!

p.s.: I hope you liked my feedback on your beta in a week. let's reconcile mid September?

lostintangent commented 5 years ago

Closing this since it’s a Chat request.