Allow specifying connection name

lostisland / faraday-net_http_persistent

Faraday Adapter for NetHttpPersistent

MIT License

12 stars 9 forks source link

Allow specifying connection name #26

Closed cocoahero closed 1 month ago

cocoahero commented 1 month ago

Allows you to pass a name: option to the adapter which is used when initializing the cached connection. This is useful when you have multiple Faraday clients using HTTP persistent, but need to tell them apart in traces, metrics, and so forth.

iMacTia commented 1 month ago

Nice and simple, with test coverage. LGTM, thank you @cocoahero 🙏 !

cocoahero commented 1 month ago

🙏🏼 @iMacTia - any idea on a timeline for getting this in a release?

iMacTia commented 1 month ago

Just trying to get #24 in as well so I can release it together with this 🙂