Handle verify hostname ssl option

lostisland / faraday

Simple, but flexible HTTP client library, with support for multiple backends.

https://lostisland.github.io/faraday

MIT License

5.72k stars 972 forks source link

Handle verify hostname ssl option #1428

Closed kazarin closed 2 years ago

kazarin commented 2 years ago

Description

Hi, This is rebased version of #1172. Next part will be in net_http adapter

Todos

List any remaining work that needs to be done, i.e:

[ ] Tests
[ ] Documentation

Additional Notes

Optional section

iMacTia commented 2 years ago

@kazarin I took a quick look and the code changes seem good. Apologies about the Rubocop issue, it seems like the latest minor version has removed a cop we've been explicitly enabling. Feel free to remove it from .rubcop.yml, that should hopefully fix tests 👍

kazarin commented 2 years ago

Done. As suggested in rubocop warning I am using now Gemspec/DeprecatedAttributeAssignment cop

iMacTia commented 2 years ago

That's even better! I didn't think it would have passed 😄 I'll have a final look