lostisland / faraday

Simple, but flexible HTTP client library, with support for multiple backends.
https://lostisland.github.io/faraday
MIT License
5.72k stars 972 forks source link

Silence Multipart/Post depreciation warnings #1455

Closed chaffeqa closed 1 year ago

chaffeqa commented 1 year ago

When starting up an app, you get:

Top level ::CompositeIO is deprecated, require 'multipart/post' and use `Multipart::Post::CompositeReadIO` instead!
Top level ::Parts is deprecated, require 'multipart/post' and use `Multipart::Post::Parts` instead!
.../faraday-0.17.5/lib/faraday/upload_io.rb:65: warning: constant ::UploadIO is deprecated
.../faraday-0.17.5/lib/faraday/upload_io.rb:66: warning: constant ::Parts is deprecated

Description

A few sentences describing the overall goals of the pull request's commits. Link to related issues if any. (As Fixes #XXX)

Todos

List any remaining work that needs to be done, i.e:

Additional Notes

Optional section

iMacTia commented 1 year ago

Thank you for opening this @chaffeqa.

We currently state the following in our gemspec:

spec.add_dependency 'multipart-post', '>= 1.2', '< 3'

Do you know if multipart/post is available in all those versions or if it was introduced later?

chaffeqa commented 1 year ago

Bleh great call... just refactored it. Not the most beautiful code, but gets the job done.

(Cannot wait until we can update faraday in our app!)

ioquatix commented 1 year ago

Thanks everyone!