undefined method `pretty_inspect` in 2.7.0 - Githubissues

lostisland / faraday

Simple, but flexible HTTP client library, with support for multiple backends.

https://lostisland.github.io/faraday

MIT License

5.72k stars 972 forks source link

undefined method `pretty_inspect` in 2.7.0 #1462

Closed SujayPrabhu96 closed 1 year ago

SujayPrabhu96 commented 1 year ago

Basic Info

Faraday Version: 2.7.0
Ruby Version: 3.1.2

Issue description

With latest version of faraday (2.7.0) logging is breaking with undefined method pretty_inspect method

Steps to reproduce

conn = Faraday.new(ENDPOINT) do |client|
   client.response :logger, nil, { headers: true, bodies: true }
end

Solution

require 'pp' is must when using pretty_inspect which has been removed in https://github.com/lostisland/faraday/pull/1457
Reference [Doc]: https://docs.ruby-lang.org/en/master/Kernel.html#method-i-pretty_inspect
Reference: https://github.com/ruby/ruby/blob/v3_1_2/lib/pp.rb#L612-L617

CHECKLIST (delete before creating the issue)

If you're not reporting a bug/issue, you can ignore this whole template.
Are you using the latest Faraday version? If not, please check the Releases page to see if the issue has already been fixed.
Provide the Faraday and Ruby Version you're using while experiencing the issue.
Fill the Issue description and Steps to Reproduce sections.
Delete this checklist before posting the issue.