ProxyOptions should treat empty string as nil

lostisland / faraday

Simple, but flexible HTTP client library, with support for multiple backends.

https://lostisland.github.io/faraday

MIT License

5.71k stars 972 forks source link

Closed exoego closed 1 year ago

exoego commented 1 year ago

After this PR, ProxyOptions treats an empty String '' as nil, so adapters can ignore the useless ProxyOption. Fixes https://github.com/lostisland/faraday/issues/1492

List any remaining work that needs to be done, i.e: