search

lostisland / faraday

Simple, but flexible HTTP client library, with support for multiple backends.
https://lostisland.github.io/faraday
MIT License
5.7k stars 971 forks source link

Add `base64` to runtime dependency #1525

Closed koic closed 10 months ago

koic commented 10 months ago

Description

This PR adds base64 to runtime dependency to suppress the following Ruby 3.3's warning:

$ ruby -ve 'require "faraday"'
ruby 3.3.0dev (2023-08-14T15:48:39Z master 52837fcec2) [x86_64-darwin22]
/Users/koic/.rbenv/versions/3.3.0-dev/lib/ruby/gems/3.3.0+0/gems/faraday-2.7.10/lib/faraday/utils.rb:3:
warning: base64 which will be not part of the default gems since Ruby 3.4.0

cf: https://github.com/rails/rails/pull/48907

Todos

List any remaining work that needs to be done, i.e:

Additional Notes

N/A