lostisland / faraday

Simple, but flexible HTTP client library, with support for multiple backends.
https://lostisland.github.io/faraday
MIT License
5.73k stars 976 forks source link

Remove runtime dependency on base64 #1541

Closed Earlopain closed 9 months ago

Earlopain commented 9 months ago

Description

1525 removed a warning in ruby 3.3 because of the base64 dependency. Only a single method in one place is used so there's no need to pull it in. Since it's just a wrapper around the pack method it's trivial to replace.

Same approach by other gems:

Earlopain commented 9 months ago

Good point with the other parts of the ecosystem. I have checked every entry on the list and its looking pretty good. No direct usage, I haven't checked transitive dependencies however. The exception being faraday-jwt which I know needs some base64 functionality, see my note on that entry below


Anything relating to faraday inside the lostisland org no

Adapters

Middleware

Speaking of the awesome faraday list, the json_request, json_response, and url_encoded links are currently 404. They are bundled in faraday itself so should be part of the check above.