search

lostisland / faraday

Simple, but flexible HTTP client library, with support for multiple backends.
https://lostisland.github.io/faraday
MIT License
5.73k stars 976 forks source link

Add logger as dependency #1573

Closed wynksaiddestroy closed 3 months ago

wynksaiddestroy commented 3 months ago

To ensure compatibility with Ruby 3.4 logger needs to be added as an explicit dependency. A deprecation warning is already shown. See the output of the RSpec step for example: https://github.com/lostisland/faraday/actions/runs/9661172692/job/26648356492

iMacTia commented 3 months ago

Note on release: unless you need this released in a timely manner, I'd wait for #1572 to be merged and then release them together as v2.10

wynksaiddestroy commented 3 months ago

Note on release: unless you need this released in a timely manner, I'd wait for #1572 to be merged and then release them together as v2.10

As long as it released before Ruby 3.4.0, there's no rush. Thanks for the quick merge.

iMacTia commented 3 months ago

I think we're good for Ruby 3.4, in the sense that we should only get the warning with that version but the code will still work. The job you linked do, in fact, run ruby 3.4.0dev and as the warning suggests logger will be removed in 3.5.0.

That said, I still want to release this as soon as possible because i) the warning is still annoying 😄 and ii) I don't want to forget about it until Ruby 3.5.0 actually arrives 🙃

iMacTia commented 2 months ago

Just released v2.10.0 with this fix 🙌 ! Thanks again for contributing 🙇

wynksaiddestroy commented 2 months ago

Just released v2.10.0 with this fix 🙌 ! Thanks again for contributing 🙇

Thank you for the quick merge and the fast release ❤️