lostisland / faraday_middleware

Various Faraday middlewares for Faraday-based API wrappers
MIT License
557 stars 203 forks source link

Update to faraday 1.0 #196

Closed BobbyMcWho closed 4 years ago

BobbyMcWho commented 5 years ago

Faraday 0.16.0 compatibility, drops support for rubies < 2.3.0, jruby and rubinius

BobbyMcWho commented 5 years ago

@olleolleolle are you maintainer over here too?

iMacTia commented 5 years ago

Parking this for now as we've released Faraday v0.17.0 which rolled back to v0.15.4

BobbyMcWho commented 5 years ago

Yeah, this will likely target a 1.0 release of faraday_middleware instead.

iMacTia commented 4 years ago

Thanks for the work @BobbyMcWho! Now that Faraday 1.0 has been released we can finally get this merged 🎉

iMacTia commented 4 years ago

Just noticed the pessimistic operator, I've relaxed that to allow v1.0 as that's the version we want to target. Breaking changes in v0.16.0 has been rolled-back in v0.17 so there's no need for these changes anymore prior to v1.0