search

lostisland / faraday_middleware

Various Faraday middlewares for Faraday-based API wrappers
MIT License
556 stars 205 forks source link

Drop `git ls-files` in gemspec #263

Closed utkarsh2102 closed 4 years ago

utkarsh2102 commented 4 years ago

Hi @olleolleolle 👋🏻

Thanks for your work on this!

Whilst maintaining this in Debian, we found that this library relies on git to produce a list of files. Using git in gemspec files in problematic, in general.

It also adds the Packaging extension of RuboCop. More about it can be found on https://docs.rubocop.org/rubocop-packaging/

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>

utkarsh2102 commented 4 years ago

@olleolleolle, hey,

~I've no clue why CI/linting fails, any clue?~

Figured! 🤦🏻

utkarsh2102 commented 4 years ago

Oh yay, all greeeeeeen! ❤️

utkarsh2102 commented 4 years ago

Hi @iMacTia,

Sorry for the slow review @utkarsh2102 ,just a couple of comments from my side!

No problem at all, thanks for your work and review! ❤️ Now that CI has passed, I hope we're good to go for merge? 😄