search

lostisland / hurley

DEAD project, don't use
MIT License
177 stars 21 forks source link

Update Minitest to 5.6.x #20

Closed kkirsche closed 9 years ago

kkirsche commented 9 years ago

Update minitest to 5.6.x

sferik commented 9 years ago

I’ll merge this but then I plan to cleanup the way we specify development dependencies.

spec.add_development_dependency "minitest", "~> 5.6", ">= 5.6.0"

This line is redundant. ~> 5.6 implies >= 5.6 (as well as < 6).

Also, IMHO, development dependencies should be specified in the Gemfile not in hurley.gemspec. Bundler allows more granular grouping of gems (e.g. development vs. test), as well as platform-specific dependencies (e.g. jruby-openssl for JRuby). Thus, I’d propose making the only development dependency:

spec.add_development_dependency "bundler", "~> 1.0"

Then we can manage everything else through the Gemfile. I’ve done this with most of the other gems I manage (including faraday) and have been pleased with the results. The only downside is that you can’t install development dependencies with the command:

gem install hurley --development

In my experience, nobody actually does gem development this way. Most people clone the repo and then run:

bundle install

I’m going to make this change here, unless there are any strong objections.