search

lostisland / sawyer

Secret User Agent of HTTP
MIT License
247 stars 75 forks source link

upgrade to addressable 2.4.0 #42

Closed mlankenau closed 8 years ago

mlankenau commented 8 years ago

I tried to include the pronto gem to our project and failed since we have the latest addressable (2.4.0) in use. This is excluded in sawyer. So It would be cool if you can pull and upgrade to 2.4.0.

fliiiix commented 8 years ago

This is also responsible to crash jekyll-gist on FreeBSD.

Would be cool if we can have a new release with addressable 2.4.0.

pengwynn commented 8 years ago

@mlankenau @fliiiix curious, are you using Octokit.rb? I'm considering folding a simplified version of this project into that project directly, removing a dependency.

pengwynn commented 8 years ago

Fixed in #44 and released in v0.7.0.

fliiiix commented 8 years ago

@pengwynn Thanks for the fast response and fix. I'm using jekyll-gist and if I'm not wrong octokit is dependency of it. So a simplified version of octokit would probably prevented this type of issue.

mlankenau commented 8 years ago

@pengwynn Our dependency chain looks like pronto-octokit-sawyer-addressable. Not sure how pronto is using octokit in detail.

mlankenau commented 8 years ago

@pengwynn And thx for the fast response :)