search

lostisland / sawyer

Secret User Agent of HTTP
MIT License
248 stars 75 forks source link

Disable yaml tests in Ruby 2.5+ because of issues with Psych 3.0 #63

Closed technoweenie closed 5 years ago

technoweenie commented 5 years ago

This should get the tests green and out of the CI "allowed failures" set. Also checks a SAWYER_YAML_ENABLED env var to run those tests anyway.

$ SAWYER_YAML_ENABLED=1 rake
/Users/rick/.rbenv/versions/2.5.3/bin/ruby -w -I"lib:lib:test" -I"/Users/rick/.rbenv/versions/2.5.3/lib/ruby/gems/2.5.0/gems/rake-12.3.2/lib" "/Users/rick/.rbenv/versions/2.5.3/lib/ruby/gems/2.5.0/gems/rake-12.3.2/lib/rake/rake_test_loader.rb" "test/agent_test.rb" "test/relation_test.rb" "test/resource_test.rb" "test/response_test.rb"
Run options: --seed 36173

# Running:

...E.....WARNING: Unexpected middleware set after the adapter. This won't be supported from Faraday 1.0.
..................................E......

Finished in 0.513981s, 97.2799 runs/s, 400.7930 assertions/s.

  1) Error:
Sawyer::AgentTest#test_handle_yaml_dump_and_load:
TypeError: allocator undefined for Method

/cc #54