lostisland / sawyer

Secret User Agent of HTTP
MIT License
247 stars 75 forks source link

Enhance Faraday Support #72

Closed iMacTia closed 2 years ago

iMacTia commented 2 years ago

Summary

cc @jrochkind

Why

Faraday v2 was recently released, and people have started having issues with upgrading due to the sometimes pretty deep dependency trees in their applications (see https://github.com/lostisland/faraday/discussions/1358#discussioncomment-2191894). octokit is a fairly popular gem that relies on sawyer, which unfortunately has not been updated in a while! This PR aims to provide rolling support to all major faraday versions, from 0.x through 1.x and even the fresh new 2.x πŸŽ‰ Once released, this will allow octokitand other gems to relax their faraday version lock and support the newest major release πŸ™Œ

Next steps

@technoweenie @pengwynn once this is approved and merged, we'd need a new release of sawyer in Rubygems. I'm happy for you to do so, but I could also do it myself if you provide me with 2 things: